media: entity: Use dedicated data link iterator
authorDaniel Scally <djrscally@gmail.com>
Thu, 7 Jul 2022 22:47:33 +0000 (23:47 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Fri, 15 Jul 2022 14:32:58 +0000 (15:32 +0100)
Where iteration over links for an entity is clearly assuming that
all of those links are data links, use the new iterator to guarantee
that assumption is met.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Daniel Scally <djrscally@gmail.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/mc/mc-entity.c

index a247d567993053585265578414e4e3a15ab6e749..cebb905260d3f02ff7e33dc1867e6a84f4c7e2c6 100644 (file)
@@ -450,7 +450,7 @@ __must_check int __media_pipeline_start(struct media_entity *entity,
                bitmap_zero(active, entity->num_pads);
                bitmap_fill(has_no_links, entity->num_pads);
 
-               list_for_each_entry(link, &entity->links, list) {
+               for_each_media_entity_data_link(entity, link) {
                        struct media_pad *pad = link->sink->entity == entity
                                                ? link->sink : link->source;
 
@@ -889,7 +889,7 @@ media_entity_find_link(struct media_pad *source, struct media_pad *sink)
 {
        struct media_link *link;
 
-       list_for_each_entry(link, &source->entity->links, list) {
+       for_each_media_entity_data_link(source->entity, link) {
                if (link->source->entity == source->entity &&
                    link->source->index == source->index &&
                    link->sink->entity == sink->entity &&
@@ -905,7 +905,7 @@ struct media_pad *media_entity_remote_pad(const struct media_pad *pad)
 {
        struct media_link *link;
 
-       list_for_each_entry(link, &pad->entity->links, list) {
+       for_each_media_entity_data_link(pad->entity, link) {
                if (!(link->flags & MEDIA_LNK_FL_ENABLED))
                        continue;