Revert "usb: gadget: hid: Convert to use list_count()"
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 Nov 2022 11:02:13 +0000 (12:02 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 Nov 2022 11:06:51 +0000 (12:06 +0100)
This reverts commit 33f00f41d963c86176dba2f9faff9b428a542e60 as it
breaks the build.

Link: https://lore.kernel.org/r/20221130131854.35b58b16@canb.auug.org.au
Link: https://lore.kernel.org/r/202211301628.iwMjPVMp-lkp@intel.com
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/legacy/hid.c

index 6196c3456e0be2126676dd1fccb99854a2944765..1187ee4f316abf5d27dea5fd251ba076ddaa2821 100644 (file)
@@ -133,11 +133,14 @@ static struct usb_configuration config_driver = {
 static int hid_bind(struct usb_composite_dev *cdev)
 {
        struct usb_gadget *gadget = cdev->gadget;
+       struct list_head *tmp;
        struct hidg_func_node *n = NULL, *m, *iter_n;
        struct f_hid_opts *hid_opts;
-       int status, funcs;
+       int status, funcs = 0;
+
+       list_for_each(tmp, &hidg_func_list)
+               funcs++;
 
-       funcs = list_count(&hidg_func_list);
        if (!funcs)
                return -ENODEV;