power: supply: Fix refcount leak in rk817_charger_probe
authorQiheng Lin <linqiheng@huawei.com>
Mon, 28 Nov 2022 14:27:40 +0000 (22:27 +0800)
committerSebastian Reichel <sebastian.reichel@collabora.com>
Sat, 3 Dec 2022 01:03:24 +0000 (02:03 +0100)
of_get_child_by_name() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.

Fixes: 11cb8da0189b ("power: supply: Add charger driver for Rockchip RK817")
Signed-off-by: Qiheng Lin <linqiheng@huawei.com>
Reviewed-by: Chris Morgan <macromorgan@hotmail.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/supply/rk817_charger.c

index 635f051b08216c3907a243589e250a5e2f4f3a15..d25a81d79facb82bbe9258523767be680a01a311 100644 (file)
@@ -1060,8 +1060,10 @@ static int rk817_charger_probe(struct platform_device *pdev)
                return -ENODEV;
 
        charger = devm_kzalloc(&pdev->dev, sizeof(*charger), GFP_KERNEL);
-       if (!charger)
+       if (!charger) {
+               of_node_put(node);
                return -ENOMEM;
+       }
 
        charger->rk808 = rk808;