media: i2c: ov5648: fix wrong pointer passed to IS_ERR() and PTR_ERR()
authorYang Yingliang <yangyingliang@huawei.com>
Tue, 30 Mar 2021 13:04:46 +0000 (15:04 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Jun 2022 08:22:59 +0000 (10:22 +0200)
[ Upstream commit a6dd5265c21c28d0a782befe41a97c347e78f22f ]

IS_ERR() and PTR_ERR() use wrong pointer, it should be
sensor->dovdd, fix it.

Fixes: e43ccb0a045f ("media: i2c: Add support for the OV5648 image sensor")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/i2c/ov5648.c

index ef8b52dc9401debc775b721b46b0e41ba01b1fb7..bb3666fc56183772f384b49fb360e6cc1489a93a 100644 (file)
@@ -2498,9 +2498,9 @@ static int ov5648_probe(struct i2c_client *client)
 
        /* DOVDD: digital I/O */
        sensor->dovdd = devm_regulator_get(dev, "dovdd");
-       if (IS_ERR(sensor->dvdd)) {
+       if (IS_ERR(sensor->dovdd)) {
                dev_err(dev, "cannot get DOVDD (digital I/O) regulator\n");
-               ret = PTR_ERR(sensor->dvdd);
+               ret = PTR_ERR(sensor->dovdd);
                goto error_endpoint;
        }