projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
3381586
)
cxl/hdm: Add debug message for invalid interleave granularity
author
Huang Ying
<ying.huang@intel.com>
Tue, 2 Apr 2024 06:10:16 +0000
(14:10 +0800)
committer
Dave Jiang
<dave.jiang@intel.com>
Tue, 30 Apr 2024 17:43:48 +0000
(10:43 -0700)
There's no debug message for invalid interleave granularity. This
makes it hard to debug related bugs. So, this is added in this patch.
Signed-off-by: Huang, Ying <ying.huang@intel.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Link:
https://lore.kernel.org/r/20240402061016.388408-1-ying.huang@intel.com
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
drivers/cxl/core/hdm.c
patch
|
blob
|
history
diff --git
a/drivers/cxl/core/hdm.c
b/drivers/cxl/core/hdm.c
index 7d97790b893d709b74fef1d66c05a6ca4150401f..973a27543ed59c3ebd145f780f863dd84e4b93e1 100644
(file)
--- a/
drivers/cxl/core/hdm.c
+++ b/
drivers/cxl/core/hdm.c
@@
-888,8
+888,12
@@
static int init_hdm_decoder(struct cxl_port *port, struct cxl_decoder *cxld,
}
rc = eig_to_granularity(FIELD_GET(CXL_HDM_DECODER0_CTRL_IG_MASK, ctrl),
&cxld->interleave_granularity);
- if (rc)
+ if (rc) {
+ dev_warn(&port->dev,
+ "decoder%d.%d: Invalid interleave granularity (ctrl: %#x)\n",
+ port->id, cxld->id, ctrl);
return rc;
+ }
dev_dbg(&port->dev, "decoder%d.%d: range: %#llx-%#llx iw: %d ig: %d\n",
port->id, cxld->id, cxld->hpa_range.start, cxld->hpa_range.end,