selftests: livepatch: Avoid running the tests if kernel-devel is missing

By checking if KDIR is a valid directory we can safely skip the tests if
kernel-devel isn't installed (default value of KDIR), or if KDIR
variable passed doesn't exists.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202402191417.XULH88Ct-lkp@intel.com/
Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>

diff --git a/tools/testing/selftests/livepatch/functions.sh b/tools/testing/selftests/livepatch/functions.sh
index e60cf09491a6663395f199360d1a8cf58c8afe4a..f0ed148d3c51f387a0d4bd3510fd04554107a1e8 100644 (file)
--- a/tools/testing/selftests/livepatch/functions.sh
+++ b/tools/testing/selftests/livepatch/functions.sh
@@ -34,6 +34,18 @@ function is_root() {
        fi
 }
 
+# Check if we can compile the modules before loading them
+function has_kdir() {
+       if [ -z "$KDIR" ]; then
+               KDIR="/lib/modules/$(uname -r)/build"
+       fi
+
+       if [ ! -d "$KDIR" ]; then
+               echo "skip all tests: KDIR ($KDIR) not available to compile modules."
+               exit $ksft_skip
+       fi
+}
+
 # die(msg) - game over, man
 #      msg - dying words
 function die() {
@@ -108,6 +120,7 @@ function cleanup() {
 #               the ftrace_enabled sysctl.
 function setup_config() {
        is_root
+       has_kdir
        push_config
        set_dynamic_debug
        set_ftrace_enabled 1

diff --git a/tools/testing/selftests/livepatch/test_modules/Makefile b/tools/testing/selftests/livepatch/test_modules/Makefile
index f5e880269bff6c851429815449549f4260b00c0e..e6e638c4bcba398a106ab2466618f6d2949e53d9 100644 (file)
--- a/tools/testing/selftests/livepatch/test_modules/Makefile
+++ b/tools/testing/selftests/livepatch/test_modules/Makefile
@@ -13,8 +13,14 @@ obj-m += test_klp_atomic_replace.o \
        test_klp_shadow_vars.o \
        test_klp_syscall.o
 
+# Ensure that KDIR exists, otherwise skip the compilation
 modules:
+ifneq ("$(wildcard $(KDIR))", "")
        $(Q)$(MAKE) -C $(KDIR) modules KBUILD_EXTMOD=$(TESTMODS_DIR)
+endif
 
+# Ensure that KDIR exists, otherwise skip the clean target
 clean:
+ifneq ("$(wildcard $(KDIR))", "")
        $(Q)$(MAKE) -C $(KDIR) clean KBUILD_EXTMOD=$(TESTMODS_DIR)
+endif