hugolib: Do not set RSS as Kind in RSS output

Before Hugo this commit  we set the pseudo page kind RSS on the page when output to RSS. This had some unintended side effects, esp. when the only output format for that page  was RSS.

For the page kinds that can have multiple output formats, the Kind should be one of the standard home, page etc.

Fixes #5138

diff --git a/hugolib/rss_test.go b/hugolib/rss_test.go
index 9b5130507972384f386b413c077bf21e0c4dcbda..d02d98a213d7314a13e9b1e728af64614f5612cd 100644 (file)
--- a/hugolib/rss_test.go
+++ b/hugolib/rss_test.go
@@ -57,3 +57,21 @@ func TestRSSOutput(t *testing.T) {
                t.Errorf("incorrect RSS item count: expected %d, got %d", rssLimit, c)
        }
 }
+
+// Before Hugo 0.49 we set the pseudo page kind RSS on the page when output to RSS.
+// This had some unintended side effects, esp. when the only output format for that page
+// was RSS.
+// For the page kinds that can have multiple output formats, the Kind should be one of the
+// standard home, page etc.
+// This test has this single purpose: Check that the Kind is that of the source page.
+// See https://github.com/gohugoio/hugo/issues/5138
+func TestRSSKind(t *testing.T) {
+       t.Parallel()
+
+       b := newTestSitesBuilder(t)
+       b.WithSimpleConfigFile().WithTemplatesAdded("index.rss.xml", `RSS Kind: {{ .Kind }}`)
+
+       b.Build(BuildCfg{})
+
+       b.AssertFileContent("public/index.xml", "RSS Kind: home")
+}

diff --git a/hugolib/site_render.go b/hugolib/site_render.go
index a0d6506e22c16165cdc7ef0c229ceb84c933b568..1f2c5c708b2bc45ac97cefa1bdbf55c0588879ef 100644 (file)
--- a/hugolib/site_render.go
+++ b/hugolib/site_render.go
@@ -248,8 +248,6 @@ func (s *Site) renderRSS(p *PageOutput) error {
                return nil
        }
 
-       p.Kind = kindRSS
-
        limit := s.Cfg.GetInt("rssLimit")
        if limit >= 0 && len(p.Pages) > limit {
                p.Pages = p.Pages[:limit]