iommu: Extend mutex lock scope in iommu_probe_device()

Extend the scope of holding group->mutex so that it can cover the default
domain check/attachment and direct mappings of reserved regions.

Cc: Ashish Mhetre <amhetre@nvidia.com>
Fixes: 211ff31b3d33b ("iommu: Fix race condition during default domain allocation")
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
Link: https://lore.kernel.org/r/20211108061349.1985579-1-baolu.lu@linux.intel.com
Signed-off-by: Joerg Roedel <jroedel@suse.de>

diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index dd7863e453a5f4d54aacd6162e80bf101c9416f8..8b86406b71627c323bac525084e265ae73dd6d83 100644 (file)
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -288,11 +288,11 @@ int iommu_probe_device(struct device *dev)
         */
        mutex_lock(&group->mutex);
        iommu_alloc_default_domain(group, dev);
-       mutex_unlock(&group->mutex);
 
        if (group->default_domain) {
                ret = __iommu_attach_device(group->default_domain, dev);
                if (ret) {
+                       mutex_unlock(&group->mutex);
                        iommu_group_put(group);
                        goto err_release;
                }
@@ -300,6 +300,7 @@ int iommu_probe_device(struct device *dev)
 
        iommu_create_device_direct_mappings(group, dev);
 
+       mutex_unlock(&group->mutex);
        iommu_group_put(group);
 
        if (ops->probe_finalize)