pps: remove usage of the deprecated ida_simple_xx() API
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 14 Apr 2024 10:10:17 +0000 (12:10 +0200)
committerAndrew Morton <akpm@linux-foundation.org>
Mon, 29 Apr 2024 15:20:06 +0000 (08:20 -0700)
ida_alloc() and ida_free() should be preferred to the deprecated
ida_simple_get() and ida_simple_remove().

This is less verbose.

Link: https://lkml.kernel.org/r/9f681747d446b874952a892491387d79ffe565a9.1713089394.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Rodolfo Giometti <giometti@enneenne.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
drivers/pps/clients/pps_parport.c

index 42f93d4c6ee329df6f2a200c06393ae59c07df2a..af972cdc04b53c8e7fec0b1456b97489c744006f 100644 (file)
@@ -148,7 +148,7 @@ static void parport_attach(struct parport *port)
                return;
        }
 
-       index = ida_simple_get(&pps_client_index, 0, 0, GFP_KERNEL);
+       index = ida_alloc(&pps_client_index, GFP_KERNEL);
        memset(&pps_client_cb, 0, sizeof(pps_client_cb));
        pps_client_cb.private = device;
        pps_client_cb.irq_func = parport_irq;
@@ -188,7 +188,7 @@ err_release_dev:
 err_unregister_dev:
        parport_unregister_device(device->pardev);
 err_free:
-       ida_simple_remove(&pps_client_index, index);
+       ida_free(&pps_client_index, index);
        kfree(device);
 }
 
@@ -208,7 +208,7 @@ static void parport_detach(struct parport *port)
        pps_unregister_source(device->pps);
        parport_release(pardev);
        parport_unregister_device(pardev);
-       ida_simple_remove(&pps_client_index, device->index);
+       ida_free(&pps_client_index, device->index);
        kfree(device);
 }