iio: multiplexer: Switch to use dev_err_probe() helper
authorYang Yingliang <yangyingliang@huawei.com>
Tue, 27 Sep 2022 06:48:41 +0000 (14:48 +0800)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Wed, 23 Nov 2022 19:43:57 +0000 (19:43 +0000)
In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs. It's more simple in error path.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20220927064841.319291-1-yangyingliang@huawei.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/multiplexer/iio-mux.c

index 93558fddfa9b41a2a03ce4133cc08543be9452b4..edd8c69f6d2e1c9ffac0ddcf5f0b4a306bc2f2d9 100644 (file)
@@ -416,11 +416,9 @@ static int mux_probe(struct platform_device *pdev)
        }
 
        mux->control = devm_mux_control_get(dev, NULL);
-       if (IS_ERR(mux->control)) {
-               if (PTR_ERR(mux->control) != -EPROBE_DEFER)
-                       dev_err(dev, "failed to get control-mux\n");
-               return PTR_ERR(mux->control);
-       }
+       if (IS_ERR(mux->control))
+               return dev_err_probe(dev, PTR_ERR(mux->control),
+                                    "failed to get control-mux\n");
 
        i = 0;
        for (state = 0; state < all_children; state++) {