gpio: aspeed: fix ast2600 bank properties
authorBilly Tsai <billy_tsai@aspeedtech.com>
Mon, 19 Oct 2020 04:50:26 +0000 (12:50 +0800)
committerBartosz Golaszewski <bgolaszewski@baylibre.com>
Mon, 26 Oct 2020 14:51:57 +0000 (15:51 +0100)
GPIO_T is mapped to the most significant byte of input/output mask, and
the byte in "output" mask should be 0 because GPIO_T is input only. All
the other bits need to be 1 because GPIO_Q/R/S support both input and
output modes.

Fixes: ab4a85534c3e ("gpio: aspeed: Add in ast2600 details to Aspeed driver")
Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
Reviewed-by: Tao Ren <rentao.bupt@gmail.com>
Reviewed-by: Joel Stanley <joel@jms.id.au>
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
drivers/gpio/gpio-aspeed.c

index e44d5de2a1201a1ecce4d6d9985c473dcc071a26..b966f5e28ebffd5f3a97bcd43f1001156641b43d 100644 (file)
@@ -1114,6 +1114,7 @@ static const struct aspeed_gpio_config ast2500_config =
 
 static const struct aspeed_bank_props ast2600_bank_props[] = {
        /*     input      output   */
+       {4, 0xffffffff,  0x00ffffff}, /* Q/R/S/T */
        {5, 0xffffffff,  0xffffff00}, /* U/V/W/X */
        {6, 0x0000ffff,  0x0000ffff}, /* Y/Z */
        { },