accel/habanalabs/gaudi2: add zero padding when printing QM CP instruction
authorTomer Tayar <ttayar@habana.ai>
Thu, 23 Nov 2023 07:49:36 +0000 (09:49 +0200)
committerOded Gabbay <ogabbay@kernel.org>
Tue, 19 Dec 2023 09:09:44 +0000 (11:09 +0200)
QM instructions are in multiples of 64 bits and the command type is in
the upper bits of first QWORD.
To make it clearer that an undefined command is due to a type of 0x0,
always print all 64 bits and add a zero padding if needed.

Signed-off-by: Tomer Tayar <ttayar@habana.ai>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
drivers/accel/habanalabs/gaudi2/gaudi2.c

index bf537c2082cda89117144d14a8df0d6ae84ef51a..f81b57649b00a620bb86c3d759155f24f8edda8d 100644 (file)
@@ -7884,7 +7884,7 @@ static void handle_lower_qman_data_on_err(struct hl_device *hdev, u64 qman_base,
        cp_current_inst = ((u64) hi) << 32 | lo;
 
        dev_info(hdev->dev,
-               "LowerQM. %sCQ: {ptr %#llx, size %u}, CP: {instruction %#llx}\n",
+               "LowerQM. %sCQ: {ptr %#llx, size %u}, CP: {instruction %#018llx}\n",
                is_arc_cq ? "ARC_" : "", cq_ptr, cq_ptr_size, cp_current_inst);
 
        if (event_mask & HL_NOTIFIER_EVENT_UNDEFINED_OPCODE) {