projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
67c3775
)
serial: max310x: add comments for membase address workaround
author
Hugo Villeneuve
<hvilleneuve@dimonoff.com>
Thu, 3 Aug 2023 14:05:51 +0000
(10:05 -0400)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Fri, 4 Aug 2023 13:07:04 +0000
(15:07 +0200)
Add comments about workaround used to configure membase address. This
follows suggestions made during review of a sc16is7xx driver patch to
add the same workaround.
Link:
https://lore.kernel.org/lkml/2936e18f-44ea-faed-9fa0-2ddefe7c3194@linux.intel.com
Link:
https://lore.kernel.org/lkml/20230801131655.80bd8f97f018dda6155d65f6@hugovil.com/
Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
Link:
https://lore.kernel.org/r/20230803140551.970141-1-hugo@hugovil.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/max310x.c
patch
|
blob
|
history
diff --git
a/drivers/tty/serial/max310x.c
b/drivers/tty/serial/max310x.c
index 416d553b73a7006365ff1ae66fd65d91aa6c5f33..5903dd033fd004aec4f34db12a7ff6d9e9c13f82 100644
(file)
--- a/
drivers/tty/serial/max310x.c
+++ b/
drivers/tty/serial/max310x.c
@@
-1369,6
+1369,11
@@
static int max310x_probe(struct device *dev, const struct max310x_devtype *devty
s->p[i].port.flags = UPF_FIXED_TYPE | UPF_LOW_LATENCY;
s->p[i].port.iotype = UPIO_PORT;
s->p[i].port.iobase = i;
+ /*
+ * Use all ones as membase to make sure uart_configure_port() in
+ * serial_core.c does not abort for SPI/I2C devices where the
+ * membase address is not applicable.
+ */
s->p[i].port.membase = (void __iomem *)~0;
s->p[i].port.uartclk = uartclk;
s->p[i].port.rs485_config = max310x_rs485_config;