extcon: Remove dup device name in the message and unneeded error check
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Wed, 22 Mar 2023 14:40:02 +0000 (16:40 +0200)
committerChanwoo Choi <cw00.choi@samsung.com>
Mon, 29 May 2023 14:41:29 +0000 (23:41 +0900)
The device name is already printed with dev_err(), no need to repeat.
The device pointer itself is not supposed to be an error point, drop
that check.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
drivers/extcon/extcon.c

index 89b3946b31232f1cb4809fc10f8e447830651dc7..47819c5144d5739f00829ce896e24ddce8462678 100644 (file)
@@ -1362,9 +1362,8 @@ void extcon_dev_unregister(struct extcon_dev *edev)
        list_del(&edev->entry);
        mutex_unlock(&extcon_dev_list_lock);
 
-       if (IS_ERR_OR_NULL(get_device(&edev->dev))) {
-               dev_err(&edev->dev, "Failed to unregister extcon_dev (%s)\n",
-                               dev_name(&edev->dev));
+       if (!get_device(&edev->dev)) {
+               dev_err(&edev->dev, "Failed to unregister extcon_dev\n");
                return;
        }