soc: mediatek: pwrap: Check return value of platform_get_irq()
authorAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Tue, 17 May 2022 10:47:10 +0000 (12:47 +0200)
committerMatthias Brugger <matthias.bgg@gmail.com>
Tue, 7 Jun 2022 16:25:14 +0000 (18:25 +0200)
Check for the return value of platform_get_irq(): if no interrupt
is specified, it wouldn't make sense to call devm_request_irq().

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20220517104712.24579-4-angelogioacchino.delregno@collabora.com
Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
drivers/soc/mediatek/mtk-pmic-wrap.c

index 852514366f1f52b9e8d0ae87aeca274eaa0980dd..04b51d21a5b0c1a21de8e76365196f0ed0879fd7 100644 (file)
@@ -2317,6 +2317,11 @@ static int pwrap_probe(struct platform_device *pdev)
                pwrap_writel(wrp, wrp->master->int1_en_all, PWRAP_INT1_EN);
 
        irq = platform_get_irq(pdev, 0);
+       if (irq < 0) {
+               ret = irq;
+               goto err_out2;
+       }
+
        ret = devm_request_irq(wrp->dev, irq, pwrap_interrupt,
                               IRQF_TRIGGER_HIGH,
                               "mt-pmic-pwrap", wrp);