bus: mhi: core: Remove unnecessary counter from mhi_firmware_copy()
authorBhaumik Bhatt <bbhatt@codeaurora.org>
Fri, 6 Nov 2020 17:44:45 +0000 (09:44 -0800)
committerManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Wed, 18 Nov 2020 09:50:34 +0000 (15:20 +0530)
There is an extra 'i' counter in the mhi_firmware_copy() function
which is unused. Remove it to clean-up code and reduce stack
space as well as improve efficiency of the function.

Fixes: cd457afb1667 ("bus: mhi: core: Add support for downloading firmware over BHIe")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
drivers/bus/mhi/core/boot.c

index 24422f5c3d808d8dfa6aada5196eba96c4e09398..6b6fd9668c3bb73010a08d413c5ca8506dbf0a36 100644 (file)
@@ -365,7 +365,6 @@ static void mhi_firmware_copy(struct mhi_controller *mhi_cntrl,
        size_t remainder = firmware->size;
        size_t to_cpy;
        const u8 *buf = firmware->data;
-       int i = 0;
        struct mhi_buf *mhi_buf = img_info->mhi_buf;
        struct bhi_vec_entry *bhi_vec = img_info->bhi_vec;
 
@@ -377,7 +376,6 @@ static void mhi_firmware_copy(struct mhi_controller *mhi_cntrl,
 
                buf += to_cpy;
                remainder -= to_cpy;
-               i++;
                bhi_vec++;
                mhi_buf++;
        }