wifi: wilc1000: fix potential memory leak in wilc_mac_xmit()
authorZhang Changzhong <zhangchangzhong@huawei.com>
Thu, 17 Nov 2022 11:36:03 +0000 (19:36 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 10 Mar 2023 08:39:07 +0000 (09:39 +0100)
[ Upstream commit deb962ec9e1c9a81babd3d37542ad4bd6ac3396e ]

The wilc_mac_xmit() returns NETDEV_TX_OK without freeing skb, add
dev_kfree_skb() to fix it. Compile tested only.

Fixes: c5c77ba18ea6 ("staging: wilc1000: Add SDIO/SPI 802.11 driver")
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/1668684964-48622-1-git-send-email-zhangchangzhong@huawei.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/microchip/wilc1000/netdev.c

index 9dfb1a285e6a4b5ad6cab594a9eef09a0d8ea831..5e3ec20e24dadc3ac3f06decb11bc691ecb5e876 100644 (file)
@@ -724,6 +724,7 @@ netdev_tx_t wilc_mac_xmit(struct sk_buff *skb, struct net_device *ndev)
 
        if (skb->dev != ndev) {
                netdev_err(ndev, "Packet not destined to this device\n");
+               dev_kfree_skb(skb);
                return NETDEV_TX_OK;
        }