i2c: amd-mp2-plat: use 'time_left' variable with wait_for_completion_timeout()
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Sat, 27 Apr 2024 20:35:53 +0000 (22:35 +0200)
committerAndi Shyti <andi.shyti@kernel.org>
Sun, 5 May 2024 22:56:49 +0000 (00:56 +0200)
There is a confusing pattern in the kernel to use a variable named 'timeout' to
store the result of wait_for_completion_timeout() causing patterns like:

timeout = wait_for_completion_timeout(...)
if (!timeout) return -ETIMEDOUT;

with all kinds of permutations. Use 'time_left' as a variable to make the code
self explaining.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
drivers/i2c/busses/i2c-amd-mp2-plat.c

index 112fe2bc5662b29052fbed9727bafaa597cdaf11..d3ac1c77a5098d730e3397a8ce5a0518f9adb050 100644 (file)
@@ -97,17 +97,17 @@ static void i2c_amd_cmd_completion(struct amd_i2c_common *i2c_common)
 static int i2c_amd_check_cmd_completion(struct amd_i2c_dev *i2c_dev)
 {
        struct amd_i2c_common *i2c_common = &i2c_dev->common;
-       unsigned long timeout;
+       unsigned long time_left;
 
-       timeout = wait_for_completion_timeout(&i2c_dev->cmd_complete,
-                                             i2c_dev->adap.timeout);
+       time_left = wait_for_completion_timeout(&i2c_dev->cmd_complete,
+                                               i2c_dev->adap.timeout);
 
        if ((i2c_common->reqcmd == i2c_read ||
             i2c_common->reqcmd == i2c_write) &&
            i2c_common->msg->len > 32)
                i2c_amd_dma_unmap(i2c_common);
 
-       if (timeout == 0) {
+       if (time_left == 0) {
                amd_mp2_rw_timeout(i2c_common);
                return -ETIMEDOUT;
        }