projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
55484fc
)
tty: n_gsm: Remove unnecessary test in gsm_print_packet()
author
Gregory CLEMENT
<gregory.clement@bootlin.com>
Mon, 18 May 2020 08:45:12 +0000
(10:45 +0200)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Tue, 19 May 2020 14:19:54 +0000
(16:19 +0200)
If the length is zero then the print_hex_dump_bytes won't output
anything, so testing the length before the call is unnecessary.
Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
Link:
https://lore.kernel.org/r/20200518084517.2173242-2-gregory.clement@bootlin.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/n_gsm.c
patch
|
blob
|
history
diff --git
a/drivers/tty/n_gsm.c
b/drivers/tty/n_gsm.c
index 69200bd411f7a0d6b258ecc23ebc754354bb60f5..4465dd04fead46c4467323a1a73f8fc3ffce8ee4 100644
(file)
--- a/
drivers/tty/n_gsm.c
+++ b/
drivers/tty/n_gsm.c
@@
-504,8
+504,7
@@
static void gsm_print_packet(const char *hdr, int addr, int cr,
else
pr_cont("(F)");
- if (dlen)
- print_hex_dump_bytes("", DUMP_PREFIX_NONE, data, dlen);
+ print_hex_dump_bytes("", DUMP_PREFIX_NONE, data, dlen);
}