ath9k: fix an IS_ERR() vs NULL check
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 11 Oct 2021 15:18:01 +0000 (18:18 +0300)
committerKalle Valo <kvalo@codeaurora.org>
Wed, 13 Oct 2021 05:48:14 +0000 (08:48 +0300)
The devm_kmemdup() function doesn't return error pointers, it returns
NULL on error.

Fixes: eb3a97a69be8 ("ath9k: fetch calibration data via nvmem subsystem")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20211011123533.GA15188@kili
drivers/net/wireless/ath/ath9k/init.c

index 0344d6f2727516fd080c7b87b19c55c066cbc892..4f00400c7ffb83545d461c623f055b73481efb02 100644 (file)
@@ -610,8 +610,8 @@ static int ath9k_nvmem_request_eeprom(struct ath_softc *sc)
        /* devres manages the calibration values release on shutdown */
        ah->nvmem_blob = (u16 *)devm_kmemdup(sc->dev, buf, len, GFP_KERNEL);
        kfree(buf);
-       if (IS_ERR(ah->nvmem_blob))
-               return PTR_ERR(ah->nvmem_blob);
+       if (!ah->nvmem_blob)
+               return -ENOMEM;
 
        ah->nvmem_blob_len = len;
        ah->ah_flags &= ~AH_USE_EEPROM;