ASoC: SOF: control: fix a typo in put operations for kcontrol
authorRander Wang <rander.wang@intel.com>
Thu, 2 Sep 2021 11:47:44 +0000 (14:47 +0300)
committerMark Brown <broonie@kernel.org>
Mon, 13 Sep 2021 00:59:16 +0000 (01:59 +0100)
SOF_CTRL_TYPE_VALUE_CHAN_SET should be used for put operations
for consistency. The current use of _GET is obviously incorrect
but _GET and _SET result in the same action so there is no
functional change introduced by this patch.

Signed-off-by: Rander Wang <rander.wang@intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://lore.kernel.org/r/20210902114744.27237-1-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/control.c

index a5dd728c580a9374ef10b1a754900ccd39380dc8..504500dd4d43cb15866f3b2d7eed162ff8ca4c29 100644 (file)
@@ -108,7 +108,7 @@ int snd_sof_volume_put(struct snd_kcontrol *kcontrol,
        if (pm_runtime_active(scomp->dev))
                snd_sof_ipc_set_get_comp_data(scontrol,
                                              SOF_IPC_COMP_SET_VALUE,
-                                             SOF_CTRL_TYPE_VALUE_CHAN_GET,
+                                             SOF_CTRL_TYPE_VALUE_CHAN_SET,
                                              SOF_CTRL_CMD_VOLUME,
                                              true);
        return change;
@@ -179,7 +179,7 @@ int snd_sof_switch_put(struct snd_kcontrol *kcontrol,
        if (pm_runtime_active(scomp->dev))
                snd_sof_ipc_set_get_comp_data(scontrol,
                                              SOF_IPC_COMP_SET_VALUE,
-                                             SOF_CTRL_TYPE_VALUE_CHAN_GET,
+                                             SOF_CTRL_TYPE_VALUE_CHAN_SET,
                                              SOF_CTRL_CMD_SWITCH,
                                              true);
 
@@ -226,7 +226,7 @@ int snd_sof_enum_put(struct snd_kcontrol *kcontrol,
        if (pm_runtime_active(scomp->dev))
                snd_sof_ipc_set_get_comp_data(scontrol,
                                              SOF_IPC_COMP_SET_VALUE,
-                                             SOF_CTRL_TYPE_VALUE_CHAN_GET,
+                                             SOF_CTRL_TYPE_VALUE_CHAN_SET,
                                              SOF_CTRL_CMD_ENUM,
                                              true);