pinctrl: stm32: do not warn when 'st,package' is absent
authorFabien Dessenne <fabien.dessenne@foss.st.com>
Fri, 8 Oct 2021 12:24:54 +0000 (14:24 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 13 Oct 2021 23:14:58 +0000 (01:14 +0200)
Since the 'st,package' property is optional, outputting the "No package
detected" warning-level log when the property is absent is unsuitable.
Remove that log.

Signed-off-by: Fabien Dessenne <fabien.dessenne@foss.st.com>
Link: https://lore.kernel.org/r/20211008122454.617556-1-fabien.dessenne@foss.st.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/stm32/pinctrl-stm32.c

index 68b3886f9f0f3cdc756020cd61cfd261dc573b44..ac82570e46beaa204809dd5cc9a185843d473267 100644 (file)
@@ -1415,17 +1415,6 @@ static int stm32_pctrl_create_pins_tab(struct stm32_pinctrl *pctl,
        return 0;
 }
 
-static void stm32_pctl_get_package(struct device_node *np,
-                                  struct stm32_pinctrl *pctl)
-{
-       if (of_property_read_u32(np, "st,package", &pctl->pkg)) {
-               pctl->pkg = 0;
-               dev_warn(pctl->dev, "No package detected, use default one\n");
-       } else {
-               dev_dbg(pctl->dev, "package detected: %x\n", pctl->pkg);
-       }
-}
-
 int stm32_pctl_probe(struct platform_device *pdev)
 {
        struct device_node *np = pdev->dev.of_node;
@@ -1473,8 +1462,9 @@ int stm32_pctl_probe(struct platform_device *pdev)
        pctl->dev = dev;
        pctl->match_data = match->data;
 
-       /*  get package information */
-       stm32_pctl_get_package(np, pctl);
+       /*  get optional package information */
+       if (!of_property_read_u32(np, "st,package", &pctl->pkg))
+               dev_dbg(pctl->dev, "package detected: %x\n", pctl->pkg);
 
        pctl->pins = devm_kcalloc(pctl->dev, pctl->match_data->npins,
                                  sizeof(*pctl->pins), GFP_KERNEL);