ceph: use dedicated list iterator variable

To move the list iterator variable into the list_for_each_entry_*()
macro in the future it should be avoided to use the list iterator
variable after the loop body.

To *never* use the list iterator variable after the loop it was
concluded to use a separate iterator variable.

Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/
Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

diff --git a/fs/ceph/caps.c b/fs/ceph/caps.c
index 5c14ef04e474247e3d98fbdacfef017c5950d217..1485a63159e31173c13caeec020486b71f725e4b 100644 (file)
--- a/fs/ceph/caps.c
+++ b/fs/ceph/caps.c
@@ -1577,7 +1577,7 @@ static void __ceph_flush_snaps(struct ceph_inode_info *ci,
 
        while (first_tid <= last_tid) {
                struct ceph_cap *cap = ci->i_auth_cap;
-               struct ceph_cap_flush *cf;
+               struct ceph_cap_flush *cf = NULL, *iter;
                int ret;
 
                if (!(cap && cap->session == session)) {
@@ -1587,8 +1587,9 @@ static void __ceph_flush_snaps(struct ceph_inode_info *ci,
                }
 
                ret = -ENOENT;
-               list_for_each_entry(cf, &ci->i_cap_flush_list, i_list) {
-                       if (cf->tid >= first_tid) {
+               list_for_each_entry(iter, &ci->i_cap_flush_list, i_list) {
+                       if (iter->tid >= first_tid) {
+                               cf = iter;
                                ret = 0;
                                break;
                        }