projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
426e580
)
powerpc/iommu: Add missing of_node_put in iommu_init_early_dart
author
Peng Wu
<wupeng58@huawei.com>
Mon, 25 Apr 2022 08:12:45 +0000
(08:12 +0000)
committer
Michael Ellerman
<mpe@ellerman.id.au>
Sun, 22 May 2022 05:58:31 +0000
(15:58 +1000)
The device_node pointer is returned by of_find_compatible_node
with refcount incremented. We should use of_node_put() to avoid
the refcount leak.
Signed-off-by: Peng Wu <wupeng58@huawei.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link:
https://lore.kernel.org/r/20220425081245.21705-1-wupeng58@huawei.com
arch/powerpc/sysdev/dart_iommu.c
patch
|
blob
|
history
diff --git
a/arch/powerpc/sysdev/dart_iommu.c
b/arch/powerpc/sysdev/dart_iommu.c
index 610ca707406611adbbf27b4b97a23c64287997ed..98096bbfd62e8d503a3bcf2029dfdf06eed8da18 100644
(file)
--- a/
arch/powerpc/sysdev/dart_iommu.c
+++ b/
arch/powerpc/sysdev/dart_iommu.c
@@
-404,9
+404,10
@@
void __init iommu_init_early_dart(struct pci_controller_ops *controller_ops)
}
/* Initialize the DART HW */
- if (dart_init(dn) != 0)
+ if (dart_init(dn) != 0) {
+ of_node_put(dn);
return;
-
+ }
/*
* U4 supports a DART bypass, we use it for 64-bit capable devices to
* improve performance. However, that only works for devices connected
@@
-419,6
+420,7
@@
void __init iommu_init_early_dart(struct pci_controller_ops *controller_ops)
/* Setup pci_dma ops */
set_pci_dma_ops(&dma_iommu_ops);
+ of_node_put(dn);
}
#ifdef CONFIG_PM