staging: vc04_services: vchiq_arm: Use appropriate dev_* log helpers
authorUmang Jain <umang.jain@ideasonboard.com>
Thu, 21 Mar 2024 13:07:34 +0000 (18:37 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 25 Mar 2024 18:09:19 +0000 (19:09 +0100)
Re-evaluate logs on error code paths and fix a few error logs
with  appropriate dev_* logging helpers.

No functional changes intended in this patch.

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Link: https://lore.kernel.org/r/20240321130737.898154-3-umang.jain@ideasonboard.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c

index 1579bd4e5263cb9c5f238184f18bbd304f9efcb0..b3021739b170d1fb15a25acd63afef684a0696fc 100644 (file)
@@ -1317,7 +1317,7 @@ vchiq_keepalive_thread_func(void *v)
                long rc = 0, uc = 0;
 
                if (wait_for_completion_interruptible(&arm_state->ka_evt)) {
-                       dev_err(state->dev, "suspend: %s: interrupted\n", __func__);
+                       dev_dbg(state->dev, "suspend: %s: interrupted\n", __func__);
                        flush_signals(current);
                        continue;
                }
@@ -1753,7 +1753,7 @@ static int vchiq_probe(struct platform_device *pdev)
         */
        err = vchiq_register_chrdev(&pdev->dev);
        if (err) {
-               dev_warn(&pdev->dev, "arm: Failed to initialize vchiq cdev\n");
+               dev_err(&pdev->dev, "arm: Failed to initialize vchiq cdev\n");
                goto error_exit;
        }
 
@@ -1763,7 +1763,7 @@ static int vchiq_probe(struct platform_device *pdev)
        return 0;
 
 failed_platform_init:
-       dev_warn(&pdev->dev, "arm: Could not initialize vchiq platform\n");
+       dev_err(&pdev->dev, "arm: Could not initialize vchiq platform\n");
 error_exit:
        return err;
 }