media: tc358746: select CONFIG_GENERIC_PHY
authorArnd Bergmann <arnd@arndb.de>
Fri, 23 Jun 2023 15:23:09 +0000 (17:23 +0200)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Wed, 28 Jun 2023 09:08:42 +0000 (11:08 +0200)
The tc358746 driver selects CONFIG_GENERIC_PHY_MIPI_DPHY and links to
that, but this fails when CONFIG_GENERIC_PHY is disabled, because Kbuild
then never enters the drivers/phy directory for building object files:

ERROR: modpost: "phy_mipi_dphy_get_default_config_for_hsclk" [drivers/media/i2c/tc358746.ko] undefined!

Add an explicit 'select GENERIC_PHY' here to ensure that the directory
is entered, and add another dependency on that symbol so make it
more obvious what is going on if another driver has the same problem,
as this will produce a Kconfig warning.

Link: https://lore.kernel.org/linux-media/20230623152318.2276816-1-arnd@kernel.org
Fixes: 80a21da360516 ("media: tc358746: add Toshiba TC358746 Parallel to CSI-2 bridge driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/i2c/Kconfig
drivers/phy/Kconfig

index cf675ac4b132653ebd4dbe6ce015cbfea4a800a4..226454b6a90dd7a25710ecfe1242d1fa5e818ecf 100644 (file)
@@ -1305,6 +1305,7 @@ config VIDEO_TC358746
        select VIDEO_V4L2_SUBDEV_API
        select MEDIA_CONTROLLER
        select V4L2_FWNODE
+       select GENERIC_PHY
        select GENERIC_PHY_MIPI_DPHY
        select REGMAP_I2C
        help
index f46e3148d286dc3c57f4419823215f2996b66c2f..8dba9596408f24c0045584b682436b090355e8a7 100644 (file)
@@ -18,6 +18,7 @@ config GENERIC_PHY
 
 config GENERIC_PHY_MIPI_DPHY
        bool
+       depends on GENERIC_PHY
        help
          Generic MIPI D-PHY support.