um: vector: fix bpfflash parameter evaluation
authorJohannes Berg <johannes.berg@intel.com>
Thu, 28 Mar 2024 09:06:36 +0000 (10:06 +0100)
committerRichard Weinberger <richard@nod.at>
Mon, 22 Apr 2024 20:28:40 +0000 (22:28 +0200)
With W=1 the build complains about a pointer compared to
zero, clearly the result should've been compared.

Fixes: 9807019a62dc ("um: Loadable BPF "Firmware" for vector drivers")
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Reviewed-by: Tiwei Bie <tiwei.btw@antgroup.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
arch/um/drivers/vector_kern.c

index dc2feae789cbb2deefee5cadff6993e9859fa5c7..63e5f108a6b95f270c87b837e0e2197314896495 100644 (file)
@@ -141,7 +141,7 @@ static bool get_bpf_flash(struct arglist *def)
 
        if (allow != NULL) {
                if (kstrtoul(allow, 10, &result) == 0)
-                       return (allow > 0);
+                       return result > 0;
        }
        return false;
 }