backlight: l4f00242t03: Simplify with dev_err_probe()

Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20240305-backlight-probe-v2-2-609b0cf24bde@linaro.org
Signed-off-by: Lee Jones <lee@kernel.org>

diff --git a/drivers/video/backlight/l4f00242t03.c b/drivers/video/backlight/l4f00242t03.c
index cc763cf15f53e695c541bd28df5f4e111af627a6..bd5137ee203badab41167203828c1e7fb031e866 100644 (file)
--- a/drivers/video/backlight/l4f00242t03.c
+++ b/drivers/video/backlight/l4f00242t03.c
@@ -179,34 +179,28 @@ static int l4f00242t03_probe(struct spi_device *spi)
        priv->spi = spi;
 
        priv->reset = devm_gpiod_get(&spi->dev, "reset", GPIOD_OUT_HIGH);
-       if (IS_ERR(priv->reset)) {
-               dev_err(&spi->dev,
-                       "Unable to get the lcd l4f00242t03 reset gpio.\n");
-               return PTR_ERR(priv->reset);
-       }
+       if (IS_ERR(priv->reset))
+               return dev_err_probe(&spi->dev, PTR_ERR(priv->reset),
+                                    "Unable to get the lcd l4f00242t03 reset gpio.\n");
        gpiod_set_consumer_name(priv->reset, "lcd l4f00242t03 reset");
 
        priv->enable = devm_gpiod_get(&spi->dev, "enable", GPIOD_OUT_LOW);
-       if (IS_ERR(priv->enable)) {
-               dev_err(&spi->dev,
-                       "Unable to get the lcd l4f00242t03 data en gpio.\n");
-               return PTR_ERR(priv->enable);
-       }
+       if (IS_ERR(priv->enable))
+               return dev_err_probe(&spi->dev, PTR_ERR(priv->enable),
+                                    "Unable to get the lcd l4f00242t03 data en gpio.\n");
        gpiod_set_consumer_name(priv->enable, "lcd l4f00242t03 data enable");
 
        priv->io_reg = devm_regulator_get(&spi->dev, "vdd");
-       if (IS_ERR(priv->io_reg)) {
-               dev_err(&spi->dev, "%s: Unable to get the IO regulator\n",
-                      __func__);
-               return PTR_ERR(priv->io_reg);
-       }
+       if (IS_ERR(priv->io_reg))
+               return dev_err_probe(&spi->dev, PTR_ERR(priv->io_reg),
+                                    "%s: Unable to get the IO regulator\n",
+                                    __func__);
 
        priv->core_reg = devm_regulator_get(&spi->dev, "vcore");
-       if (IS_ERR(priv->core_reg)) {
-               dev_err(&spi->dev, "%s: Unable to get the core regulator\n",
-                      __func__);
-               return PTR_ERR(priv->core_reg);
-       }
+       if (IS_ERR(priv->core_reg))
+               return dev_err_probe(&spi->dev, PTR_ERR(priv->core_reg),
+                                    "%s: Unable to get the core regulator\n",
+                                    __func__);
 
        priv->ld = devm_lcd_device_register(&spi->dev, "l4f00242t03", &spi->dev,
                                        priv, &l4f_ops);