spi: spi-tegra114: using pm_runtime_resume_and_get instead of pm_runtime_get_sync
authorMinghao Chi <chi.minghao@zte.com.cn>
Tue, 12 Apr 2022 07:09:51 +0000 (07:09 +0000)
committerMark Brown <broonie@kernel.org>
Tue, 19 Apr 2022 12:13:44 +0000 (13:13 +0100)
Using pm_runtime_resume_and_get is more appropriate
for simplifing code

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
Link: https://lore.kernel.org/r/20220412070951.2532157-1-chi.minghao@zte.com.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-tegra114.c

index 8f345247a8c3221417c2f9df498b4d39a2727a40..d9be80e3e1bcb52581af65c090b8de0b9ccc509c 100644 (file)
@@ -964,9 +964,8 @@ static int tegra_spi_setup(struct spi_device *spi)
                spi->controller_data = cdata;
        }
 
-       ret = pm_runtime_get_sync(tspi->dev);
+       ret = pm_runtime_resume_and_get(tspi->dev);
        if (ret < 0) {
-               pm_runtime_put_noidle(tspi->dev);
                dev_err(tspi->dev, "pm runtime failed, e = %d\n", ret);
                if (cdata)
                        tegra_spi_cleanup(spi);
@@ -1394,10 +1393,9 @@ static int tegra_spi_probe(struct platform_device *pdev)
                        goto exit_pm_disable;
        }
 
-       ret = pm_runtime_get_sync(&pdev->dev);
+       ret = pm_runtime_resume_and_get(&pdev->dev);
        if (ret < 0) {
                dev_err(&pdev->dev, "pm runtime get failed, e = %d\n", ret);
-               pm_runtime_put_noidle(&pdev->dev);
                goto exit_pm_disable;
        }
 
@@ -1476,9 +1474,8 @@ static int tegra_spi_resume(struct device *dev)
        struct tegra_spi_data *tspi = spi_master_get_devdata(master);
        int ret;
 
-       ret = pm_runtime_get_sync(dev);
+       ret = pm_runtime_resume_and_get(dev);
        if (ret < 0) {
-               pm_runtime_put_noidle(dev);
                dev_err(dev, "pm runtime failed, e = %d\n", ret);
                return ret;
        }