usb: ohci-nxp: Fix refcount leak in ohci_hcd_nxp_probe
authorMiaoqian Lin <linmq006@gmail.com>
Fri, 3 Jun 2022 14:12:30 +0000 (18:12 +0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Aug 2022 12:23:41 +0000 (14:23 +0200)
[ Upstream commit 302970b4cad3ebfda2c05ce06c322ccdc447d17e ]

of_parse_phandle() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.

Fixes: 73108aa90cbf ("USB: ohci-nxp: Use isp1301 driver")
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220603141231.979-1-linmq006@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/usb/host/ohci-nxp.c

index 85878e8ad3311b316e0cc3a19da201e9bdccb9d9..106a6bcefb0871991099c0e229e8b379151ae0d0 100644 (file)
@@ -164,6 +164,7 @@ static int ohci_hcd_nxp_probe(struct platform_device *pdev)
        }
 
        isp1301_i2c_client = isp1301_get_client(isp1301_node);
+       of_node_put(isp1301_node);
        if (!isp1301_i2c_client)
                return -EPROBE_DEFER;