habanalabs: added return value check for hl_fw_dynamic_send_clear_cmd()

The clang-analyzer reported a warning: "Value stored to 'rc' is never
read".

The return value check for the first hl_fw_dynamic_send_clear_cmd() call
in hl_fw_dynamic_send_protocol_cmd() appears to be missing.

Signed-off-by: Marco Pagani <marpagan@redhat.com>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>

diff --git a/drivers/misc/habanalabs/common/firmware_if.c b/drivers/misc/habanalabs/common/firmware_if.c
index 01c4ffba6e9735870897685260f320f3201b18ad..c0909d76d6eb26626c5f97a4ce128079bc4b2377 100644 (file)
--- a/drivers/misc/habanalabs/common/firmware_if.c
+++ b/drivers/misc/habanalabs/common/firmware_if.c
@@ -1783,6 +1783,8 @@ int hl_fw_dynamic_send_protocol_cmd(struct hl_device *hdev,
 
        /* first send clear command to clean former commands */
        rc = hl_fw_dynamic_send_clear_cmd(hdev, fw_loader);
+       if (rc)
+               return rc;
 
        /* send the actual command */
        hl_fw_dynamic_send_cmd(hdev, fw_loader, cmd, size);