media: mediatek: mdp3: replace return by goto for proper unwind
authorHans Verkuil <hverkuil-cisco@xs4all.nl>
Thu, 26 Jan 2023 12:56:20 +0000 (13:56 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Wed, 8 Feb 2023 07:38:56 +0000 (08:38 +0100)
An error was returned at one point without going through the
goto label for proper unwinding.

This fixes a smatch warning:

mtk-mdp3-comp.c:1005 mdp_comp_config() warn: missing unwind goto?

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: Moudy Ho <moudy.ho@mediatek.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c

index 7bc05f42a23c183255bfcdc3223456e9d0a7abdf..091a68685590425b5f7cf8711d94c2e708525001 100644 (file)
@@ -1002,7 +1002,8 @@ int mdp_comp_config(struct mdp_dev *mdp)
                if (!pdev) {
                        dev_warn(dev, "can't find platform device of node:%s\n",
                                 node->name);
-                       return -ENODEV;
+                       ret = -ENODEV;
+                       goto err_init_comps;
                }
 
                comp->comp_dev = &pdev->dev;