usb/phy-isp1301-omap: Remove .data assignment
authorKees Cook <keescook@chromium.org>
Wed, 20 Sep 2017 23:27:40 +0000 (16:27 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 4 Oct 2017 07:57:03 +0000 (09:57 +0200)
The .data assignment appears to be redundant to the WORK_STOP bit for
stopping the timer. Also, it appears this timer is entirely unused
as it is only ever started under #define VERBOSE, which is explicitly
undefined.

Signed-off-by: Kees Cook <keescook@chromium.org>
Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/phy/phy-isp1301-omap.c

index c6052c814bcc24bb51bd4c1a82de48cfb8719de9..718026bed1b6b70615f0bb3613a49a21e469493d 100644 (file)
@@ -1222,7 +1222,6 @@ static int isp1301_remove(struct i2c_client *i2c)
        if (machine_is_omap_h2())
                gpio_free(2);
 
-       isp->timer.data = 0;
        set_bit(WORK_STOP, &isp->todo);
        del_timer_sync(&isp->timer);
        flush_work(&isp->work);