staging: r8188eu: remove duplicate category check
authorMartin Kaiser <martin@kaiser.cx>
Sun, 30 Oct 2022 17:33:15 +0000 (18:33 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 31 Oct 2022 08:09:02 +0000 (09:09 +0100)
The caller of on_action_public has already checked the action category. We
can remove the check in on_action_public.

Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20221030173326.1588647-3-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/core/rtw_mlme_ext.c

index 5a366688a3f7dac385a1c1fffe05bad1c9d229c0..7d4f208d161bb9f8b5524ae37573c1b58edb1c60 100644 (file)
@@ -3819,16 +3819,12 @@ unsigned int on_action_public(struct adapter *padapter, struct recv_frame *precv
        unsigned int ret = _FAIL;
        u8 *pframe = precv_frame->rx_data;
        u8 *frame_body = pframe + sizeof(struct ieee80211_hdr_3addr);
-       u8 category, action;
+       u8 action;
 
        /* check RA matches or not */
        if (memcmp(myid(&padapter->eeprompriv), mgmt->da, ETH_ALEN))
                goto exit;
 
-       category = frame_body[0];
-       if (category != WLAN_CATEGORY_PUBLIC)
-               goto exit;
-
        action = frame_body[1];
        switch (action) {
        case ACT_PUBLIC_VENDOR: