wifi: mt76: mt7921: add mt7921_mutex_acquire at mt7921_sta_set_decap_offload
authorSean Wang <sean.wang@mediatek.com>
Fri, 29 Jul 2022 14:44:57 +0000 (22:44 +0800)
committerFelix Fietkau <nbd@nbd.name>
Thu, 15 Sep 2022 10:54:01 +0000 (12:54 +0200)
Add mt7921_mutex_acquire at mt7921_[start, stop]_ap to fix the race
with the context holding dev->muxtex and the driver might access the
device in low power state.

Fixes: 24299fc869f7 ("mt76: mt7921: enable rx header traslation offload")
Tested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/mt7921/main.c

index 63fd33dcd3af513a9c3b42578105f962a042529b..7214735011d04b07e94baa6c666a865f452a0d9f 100644 (file)
@@ -1404,6 +1404,8 @@ static void mt7921_sta_set_decap_offload(struct ieee80211_hw *hw,
        struct mt7921_sta *msta = (struct mt7921_sta *)sta->drv_priv;
        struct mt7921_dev *dev = mt7921_hw_dev(hw);
 
+       mt7921_mutex_acquire(dev);
+
        if (enabled)
                set_bit(MT_WCID_FLAG_HDR_TRANS, &msta->wcid.flags);
        else
@@ -1411,6 +1413,8 @@ static void mt7921_sta_set_decap_offload(struct ieee80211_hw *hw,
 
        mt76_connac_mcu_sta_update_hdr_trans(&dev->mt76, vif, &msta->wcid,
                                             MCU_UNI_CMD(STA_REC_UPDATE));
+
+       mt7921_mutex_release(dev);
 }
 
 #if IS_ENABLED(CONFIG_IPV6)