Include path to source page in non-relative ref/relref warning
authorJustin Van Patten <jvp@justinvp.com>
Wed, 26 Jun 2019 06:26:02 +0000 (23:26 -0700)
committerBjørn Erik Pedersen <bjorn.erik.pedersen@gmail.com>
Wed, 26 Jun 2019 07:25:12 +0000 (09:25 +0200)
We occasionally see warnings when building our site:

```
WARN 2019/06/25 23:07:08 make non-relative ref/relref page reference(s) in page %q absolute, e.g. {{< ref "/blog/my-post.md" >}}
```

But the `%q` value is missing, making it difficult to track down the source of the warning.

This change addresses that, by including the source path in the warning:

```
WARN 2019/06/25 23:07:31 make non-relative ref/relref page reference(s) in page "blog/my-post/index.md" absolute, e.g. {{< ref "/blog/my-post.md" >}}
```

hugolib/pagecollections.go

index f62ea0905dc726b13d8e384bdcc8e98ab1b0d16c..24318232034794f7ffe691fe8044ded4a9dd8afa 100644 (file)
@@ -283,7 +283,7 @@ func (c *PageCollections) getPageNew(context page.Page, ref string) (page.Page,
                if err == nil && p != nil {
                        if context != nil {
                                // TODO(bep) remove this case and the message below when the storm has passed
-                               err := wrapErr(errors.New(`make non-relative ref/relref page reference(s) in page %q absolute, e.g. {{< ref "/blog/my-post.md" >}}`), context)
+                               err := wrapErr(errors.Errorf(`make non-relative ref/relref page reference(s) in page %q absolute, e.g. {{< ref "/blog/my-post.md" >}}`, context.Path()), context)
                                helpers.DistinctWarnLog.Println(err)
                        }
                        return p, nil