staging: vt6655: Replace MACvTransmit0 with function vt6655_mac_dma_ctl
authorPhilipp Hortmann <philipp.g.hortmann@gmail.com>
Fri, 29 Jul 2022 08:14:46 +0000 (10:14 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 16 Aug 2022 13:09:55 +0000 (15:09 +0200)
Convert macro MACvTransmit0 to existing static function. This saves
codelines and multiline macros are not liked by kernel community.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/fc412f0fda11045a55b6b5867d51e250ca841ee8.1659080988.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vt6655/device_main.c
drivers/staging/vt6655/mac.h

index ca38a38565f7c2705af13163dd4ea38f87f395e1..ec26d2d29d8412069358eeb7a6f1bea06dc8422c 100644 (file)
@@ -1231,7 +1231,7 @@ static int vnt_tx_packet(struct vnt_private *priv, struct sk_buff *skb)
        if (head_td->td_info->flags & TD_FLAGS_NETIF_SKB)
                MACvTransmitAC0(priv->port_offset);
        else
-               MACvTransmit0(priv->port_offset);
+               vt6655_mac_dma_ctl(priv->port_offset, MAC_REG_TXDMACTL0);
 
        priv->iTDUsed[dma_idx]++;
 
index 5a473ca393f206d297fb3d17e49f90dcad2ffd2c..be33da59dd84f413ecbdc5ec05961f6a130d0b81 100644 (file)
 
 /*---------------------  Export Macros ------------------------------*/
 
-#define MACvTransmit0(iobase)                                          \
-do {                                                                   \
-       unsigned long dwData;                                           \
-       dwData = ioread32(iobase + MAC_REG_TXDMACTL0);                  \
-       if (dwData & DMACTL_RUN)                                        \
-               iowrite32(DMACTL_WAKE, iobase + MAC_REG_TXDMACTL0);     \
-       else                                                            \
-               iowrite32(DMACTL_RUN, iobase + MAC_REG_TXDMACTL0);      \
-} while (0)
-
 #define MACvTransmitAC0(iobase)                                        \
 do {                                                                   \
        unsigned long dwData;                                           \