media: marvell: change return to goto for proper unwind
authorHans Verkuil <hverkuil-cisco@xs4all.nl>
Thu, 26 Jan 2023 12:33:10 +0000 (13:33 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Wed, 8 Feb 2023 07:31:49 +0000 (08:31 +0100)
The probe function used 'goto out' everywhere, except in one
place where it returned an error. That too should be a 'goto out'.

This fixes a smatch warning:

mmp-driver.c:257 mmpcam_probe() warn: missing unwind goto?

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/platform/marvell/mmp-driver.c

index df16899ab1cbe1a27577a6e3f93875fb3d1817f4..ef22bf8f276ca5a8d68e098d259cc40fee926097 100644 (file)
@@ -254,7 +254,7 @@ static int mmpcam_probe(struct platform_device *pdev)
         */
        ret = mccic_register(mcam);
        if (ret)
-               return ret;
+               goto out;
 
        /*
         * Add OF clock provider.