powerpc/pseries: Move mm/book3s64/vphn.c under platforms/pseries/
authorNaveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Wed, 3 Jul 2019 17:03:59 +0000 (22:33 +0530)
committerMichael Ellerman <mpe@ellerman.id.au>
Thu, 4 Jul 2019 12:23:38 +0000 (22:23 +1000)
hcall_vphn() is specific to pseries and will be used in a subsequent
patch. So, move it to a more appropriate place under
arch/powerpc/platforms/pseries. Also merge vphn.h into lppaca.h
and update vphn selftest to use the new files.

Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/include/asm/lppaca.h
arch/powerpc/mm/book3s64/Makefile
arch/powerpc/mm/book3s64/vphn.c [deleted file]
arch/powerpc/mm/book3s64/vphn.h [deleted file]
arch/powerpc/mm/numa.c
arch/powerpc/platforms/pseries/Makefile
arch/powerpc/platforms/pseries/vphn.c [new file with mode: 0644]
tools/testing/selftests/powerpc/vphn/Makefile
tools/testing/selftests/powerpc/vphn/asm/lppaca.h [new symlink]
tools/testing/selftests/powerpc/vphn/vphn.c
tools/testing/selftests/powerpc/vphn/vphn.h [deleted symlink]

index e45b7293414deac98dc074128e1e47a0ff8b156e..f5195b4d9ffb3d09416e313864d622bf69d15e0c 100644 (file)
  */
 #ifndef _ASM_POWERPC_LPPACA_H
 #define _ASM_POWERPC_LPPACA_H
+
+/*
+ * The below VPHN macros are outside the __KERNEL__ check since these are
+ * used for compiling the vphn selftest in userspace
+ */
+
+/* The H_HOME_NODE_ASSOCIATIVITY h_call returns 6 64-bit registers. */
+#define VPHN_REGISTER_COUNT 6
+
+/*
+ * 6 64-bit registers unpacked into up to 24 be32 associativity values. To
+ * form the complete property we have to add the length in the first cell.
+ */
+#define VPHN_ASSOC_BUFSIZE (VPHN_REGISTER_COUNT*sizeof(u64)/sizeof(u16) + 1)
+
+/*
+ * The H_HOME_NODE_ASSOCIATIVITY hcall takes two values for flags:
+ * 1 for retrieving associativity information for a guest cpu
+ * 2 for retrieving associativity information for a host/hypervisor cpu
+ */
+#define VPHN_FLAG_VCPU 1
+#define VPHN_FLAG_PCPU 2
+
 #ifdef __KERNEL__
 
 /*
@@ -179,6 +202,7 @@ extern void (*dtl_consumer)(struct dtl_entry *entry, u64 index);
 
 extern void register_dtl_buffer(int cpu);
 extern void alloc_dtl_buffers(void);
+extern long hcall_vphn(unsigned long cpu, u64 flags, __be32 *associativity);
 
 #endif /* CONFIG_PPC_BOOK3S */
 #endif /* __KERNEL__ */
index 974b4fc19f4f19ebea8c2e1390826b7beea9d021..fd393b8be14fd23d6394acf7ec006e29708e9006 100644 (file)
@@ -10,7 +10,6 @@ obj-$(CONFIG_PPC_NATIVE)      += hash_native.o
 obj-$(CONFIG_PPC_RADIX_MMU)    += radix_pgtable.o radix_tlb.o
 obj-$(CONFIG_PPC_4K_PAGES)     += hash_4k.o
 obj-$(CONFIG_PPC_64K_PAGES)    += hash_64k.o
-obj-$(CONFIG_PPC_SPLPAR)       += vphn.o
 obj-$(CONFIG_HUGETLB_PAGE)     += hash_hugetlbpage.o
 ifdef CONFIG_HUGETLB_PAGE
 obj-$(CONFIG_PPC_RADIX_MMU)    += radix_hugetlbpage.o
diff --git a/arch/powerpc/mm/book3s64/vphn.c b/arch/powerpc/mm/book3s64/vphn.c
deleted file mode 100644 (file)
index 0ee7734..0000000
+++ /dev/null
@@ -1,73 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-#include <asm/byteorder.h>
-#include "vphn.h"
-
-/*
- * The associativity domain numbers are returned from the hypervisor as a
- * stream of mixed 16-bit and 32-bit fields. The stream is terminated by the
- * special value of "all ones" (aka. 0xffff) and its size may not exceed 48
- * bytes.
- *
- *    --- 16-bit fields -->
- *  _________________________
- *  |  0  |  1  |  2  |  3  |   be_packed[0]
- *  ------+-----+-----+------
- *  _________________________
- *  |  4  |  5  |  6  |  7  |   be_packed[1]
- *  -------------------------
- *            ...
- *  _________________________
- *  | 20  | 21  | 22  | 23  |   be_packed[5]
- *  -------------------------
- *
- * Convert to the sequence they would appear in the ibm,associativity property.
- */
-int vphn_unpack_associativity(const long *packed, __be32 *unpacked)
-{
-       __be64 be_packed[VPHN_REGISTER_COUNT];
-       int i, nr_assoc_doms = 0;
-       const __be16 *field = (const __be16 *) be_packed;
-       u16 last = 0;
-       bool is_32bit = false;
-
-#define VPHN_FIELD_UNUSED      (0xffff)
-#define VPHN_FIELD_MSB         (0x8000)
-#define VPHN_FIELD_MASK                (~VPHN_FIELD_MSB)
-
-       /* Let's fix the values returned by plpar_hcall9() */
-       for (i = 0; i < VPHN_REGISTER_COUNT; i++)
-               be_packed[i] = cpu_to_be64(packed[i]);
-
-       for (i = 1; i < VPHN_ASSOC_BUFSIZE; i++) {
-               u16 new = be16_to_cpup(field++);
-
-               if (is_32bit) {
-                       /*
-                        * Let's concatenate the 16 bits of this field to the
-                        * 15 lower bits of the previous field
-                        */
-                       unpacked[++nr_assoc_doms] =
-                               cpu_to_be32(last << 16 | new);
-                       is_32bit = false;
-               } else if (new == VPHN_FIELD_UNUSED)
-                       /* This is the list terminator */
-                       break;
-               else if (new & VPHN_FIELD_MSB) {
-                       /* Data is in the lower 15 bits of this field */
-                       unpacked[++nr_assoc_doms] =
-                               cpu_to_be32(new & VPHN_FIELD_MASK);
-               } else {
-                       /*
-                        * Data is in the lower 15 bits of this field
-                        * concatenated with the next 16 bit field
-                        */
-                       last = new;
-                       is_32bit = true;
-               }
-       }
-
-       /* The first cell contains the length of the property */
-       unpacked[0] = cpu_to_be32(nr_assoc_doms);
-
-       return nr_assoc_doms;
-}
diff --git a/arch/powerpc/mm/book3s64/vphn.h b/arch/powerpc/mm/book3s64/vphn.h
deleted file mode 100644 (file)
index f7ff1e0..0000000
+++ /dev/null
@@ -1,24 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-#ifndef _ARCH_POWERPC_MM_VPHN_H_
-#define _ARCH_POWERPC_MM_VPHN_H_
-
-/* The H_HOME_NODE_ASSOCIATIVITY h_call returns 6 64-bit registers. */
-#define VPHN_REGISTER_COUNT 6
-
-/*
- * 6 64-bit registers unpacked into up to 24 be32 associativity values. To
- * form the complete property we have to add the length in the first cell.
- */
-#define VPHN_ASSOC_BUFSIZE (VPHN_REGISTER_COUNT*sizeof(u64)/sizeof(u16) + 1)
-
-/*
- * The H_HOME_NODE_ASSOCIATIVITY hcall takes two values for flags:
- * 1 for retrieving associativity information for a guest cpu
- * 2 for retrieving associativity information for a host/hypervisor cpu
- */
-#define VPHN_FLAG_VCPU 1
-#define VPHN_FLAG_PCPU 2
-
-extern int vphn_unpack_associativity(const long *packed, __be32 *unpacked);
-
-#endif
index 57f006b6214ba0d19ebfe5e766e99ea42126df40..50fadc99897b4dc685f37124ba5182117493cabd 100644 (file)
@@ -1067,9 +1067,6 @@ u64 memory_hotplug_max(void)
 
 /* Virtual Processor Home Node (VPHN) support */
 #ifdef CONFIG_PPC_SPLPAR
-
-#include "book3s64/vphn.h"
-
 struct topology_update_data {
        struct topology_update_data *next;
        unsigned int cpu;
@@ -1087,17 +1084,6 @@ static void reset_topology_timer(void);
 static int topology_timer_secs = 1;
 static int topology_inited;
 
-static long hcall_vphn(unsigned long cpu, u64 flags, __be32 *associativity)
-{
-       long rc;
-       long retbuf[PLPAR_HCALL9_BUFSIZE] = {0};
-
-       rc = plpar_hcall9(H_HOME_NODE_ASSOCIATIVITY, retbuf, flags, cpu);
-       vphn_unpack_associativity(retbuf, associativity);
-
-       return rc;
-}
-
 /*
  * Change polling interval for associativity changes.
  */
index a43ec843c8e2a119b29d5078aad12bbb9922843e..ab3d59aeaccaaa07c8303a629f694eabdbfc961b 100644 (file)
@@ -25,6 +25,7 @@ obj-$(CONFIG_LPARCFG)         += lparcfg.o
 obj-$(CONFIG_IBMVIO)           += vio.o
 obj-$(CONFIG_IBMEBUS)          += ibmebus.o
 obj-$(CONFIG_PAPR_SCM)         += papr_scm.o
+obj-$(CONFIG_PPC_SPLPAR)       += vphn.o
 
 ifdef CONFIG_PPC_PSERIES
 obj-$(CONFIG_SUSPEND)          += suspend.o
diff --git a/arch/powerpc/platforms/pseries/vphn.c b/arch/powerpc/platforms/pseries/vphn.c
new file mode 100644 (file)
index 0000000..3f07bf6
--- /dev/null
@@ -0,0 +1,89 @@
+// SPDX-License-Identifier: GPL-2.0
+#include <asm/byteorder.h>
+#include <asm/lppaca.h>
+
+/*
+ * The associativity domain numbers are returned from the hypervisor as a
+ * stream of mixed 16-bit and 32-bit fields. The stream is terminated by the
+ * special value of "all ones" (aka. 0xffff) and its size may not exceed 48
+ * bytes.
+ *
+ *    --- 16-bit fields -->
+ *  _________________________
+ *  |  0  |  1  |  2  |  3  |   be_packed[0]
+ *  ------+-----+-----+------
+ *  _________________________
+ *  |  4  |  5  |  6  |  7  |   be_packed[1]
+ *  -------------------------
+ *            ...
+ *  _________________________
+ *  | 20  | 21  | 22  | 23  |   be_packed[5]
+ *  -------------------------
+ *
+ * Convert to the sequence they would appear in the ibm,associativity property.
+ */
+static int vphn_unpack_associativity(const long *packed, __be32 *unpacked)
+{
+       __be64 be_packed[VPHN_REGISTER_COUNT];
+       int i, nr_assoc_doms = 0;
+       const __be16 *field = (const __be16 *) be_packed;
+       u16 last = 0;
+       bool is_32bit = false;
+
+#define VPHN_FIELD_UNUSED      (0xffff)
+#define VPHN_FIELD_MSB         (0x8000)
+#define VPHN_FIELD_MASK                (~VPHN_FIELD_MSB)
+
+       /* Let's fix the values returned by plpar_hcall9() */
+       for (i = 0; i < VPHN_REGISTER_COUNT; i++)
+               be_packed[i] = cpu_to_be64(packed[i]);
+
+       for (i = 1; i < VPHN_ASSOC_BUFSIZE; i++) {
+               u16 new = be16_to_cpup(field++);
+
+               if (is_32bit) {
+                       /*
+                        * Let's concatenate the 16 bits of this field to the
+                        * 15 lower bits of the previous field
+                        */
+                       unpacked[++nr_assoc_doms] =
+                               cpu_to_be32(last << 16 | new);
+                       is_32bit = false;
+               } else if (new == VPHN_FIELD_UNUSED)
+                       /* This is the list terminator */
+                       break;
+               else if (new & VPHN_FIELD_MSB) {
+                       /* Data is in the lower 15 bits of this field */
+                       unpacked[++nr_assoc_doms] =
+                               cpu_to_be32(new & VPHN_FIELD_MASK);
+               } else {
+                       /*
+                        * Data is in the lower 15 bits of this field
+                        * concatenated with the next 16 bit field
+                        */
+                       last = new;
+                       is_32bit = true;
+               }
+       }
+
+       /* The first cell contains the length of the property */
+       unpacked[0] = cpu_to_be32(nr_assoc_doms);
+
+       return nr_assoc_doms;
+}
+
+/* NOTE: This file is included by a selftest and built in userspace. */
+#ifdef __KERNEL__
+#include <asm/hvcall.h>
+
+long hcall_vphn(unsigned long cpu, u64 flags, __be32 *associativity)
+{
+       long rc;
+       long retbuf[PLPAR_HCALL9_BUFSIZE] = {0};
+
+       rc = plpar_hcall9(H_HOME_NODE_ASSOCIATIVITY, retbuf, flags, cpu);
+       vphn_unpack_associativity(retbuf, associativity);
+
+       return rc;
+}
+#endif
index 18b885da01bd6000bb307d10f4986931b0a5d2c9..cf65cbf33085aa053ec22b28b95d9283ae0d7c0b 100644 (file)
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0-only
 TEST_GEN_PROGS := test-vphn
 
-CFLAGS += -m64
+CFLAGS += -m64 -I$(CURDIR)
 
 top_srcdir = ../../../../..
 include ../../lib.mk
diff --git a/tools/testing/selftests/powerpc/vphn/asm/lppaca.h b/tools/testing/selftests/powerpc/vphn/asm/lppaca.h
new file mode 120000 (symlink)
index 0000000..942b1d0
--- /dev/null
@@ -0,0 +1 @@
+../../../../../../arch/powerpc/include/asm/lppaca.h
\ No newline at end of file
index 1d1f5f2be3b295bdc199c3329b05ec8ecddea293..5b5fbddccabd93bb4a683777683d6bf765640859 120000 (symlink)
@@ -1 +1 @@
-../../../../../arch/powerpc/mm/book3s64/vphn.c
\ No newline at end of file
+../../../../../arch/powerpc/platforms/pseries/vphn.c
\ No newline at end of file
diff --git a/tools/testing/selftests/powerpc/vphn/vphn.h b/tools/testing/selftests/powerpc/vphn/vphn.h
deleted file mode 120000 (symlink)
index 45fe160..0000000
+++ /dev/null
@@ -1 +0,0 @@
-../../../../../arch/powerpc/mm/book3s64/vphn.h
\ No newline at end of file