projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
656f7fc
)
phy: rockchip-inno-usb2: Do not lock in bvalid IRQ handler
author
Samuel Holland
<samuel@sholland.org>
Thu, 14 Apr 2022 03:22:54 +0000
(22:22 -0500)
committer
Vinod Koul
<vkoul@kernel.org>
Wed, 20 Apr 2022 09:14:03 +0000
(14:44 +0530)
Clearing the IRQ is atomic, so there is no need to hold the mutex.
Signed-off-by: Samuel Holland <samuel@sholland.org>
Tested-by: Michael Riesch <michael.riesch@wolfvision.net>
Link:
https://lore.kernel.org/r/20220414032258.40984-4-samuel@sholland.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/rockchip/phy-rockchip-inno-usb2.c
patch
|
blob
|
history
diff --git
a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
index 29407b36f5fa7c4042b93aab6fadc3f6bad3c8dc..3422db56be76b735e02e166d06428eff23a548b1 100644
(file)
--- a/
drivers/phy/rockchip/phy-rockchip-inno-usb2.c
+++ b/
drivers/phy/rockchip/phy-rockchip-inno-usb2.c
@@
-905,13
+905,9
@@
static irqreturn_t rockchip_usb2phy_bvalid_irq(int irq, void *data)
if (!property_enabled(rphy->grf, &rport->port_cfg->bvalid_det_st))
return IRQ_NONE;
- mutex_lock(&rport->mutex);
-
/* clear bvalid detect irq pending status */
property_enable(rphy->grf, &rport->port_cfg->bvalid_det_clr, true);
- mutex_unlock(&rport->mutex);
-
rockchip_usb2phy_otg_sm_work(&rport->otg_sm_work.work);
return IRQ_HANDLED;