target/i386: Construct CPUID 2 as stateful iff times > 1
authorXiaoyao Li <xiaoyao.li@intel.com>
Wed, 14 Aug 2024 07:54:27 +0000 (03:54 -0400)
committerPaolo Bonzini <pbonzini@redhat.com>
Thu, 17 Oct 2024 10:30:21 +0000 (12:30 +0200)
When times == 1, the CPUID leaf 2 is not stateful.

Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
Link: https://lore.kernel.org/r/20240814075431.339209-6-xiaoyao.li@intel.com
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
target/i386/kvm/kvm.c

index 6f6301460d4522d2503d36e20598ec8813bfb3df..77e88165707a1b5f4475601839d3bb56fffc6a41 100644 (file)
@@ -1838,10 +1838,12 @@ static uint32_t kvm_x86_build_cpuid(CPUX86State *env,
             int times;
 
             c->function = i;
-            c->flags = KVM_CPUID_FLAG_STATEFUL_FUNC |
-                       KVM_CPUID_FLAG_STATE_READ_NEXT;
             cpu_x86_cpuid(env, i, 0, &c->eax, &c->ebx, &c->ecx, &c->edx);
             times = c->eax & 0xff;
+            if (times > 1) {
+                c->flags = KVM_CPUID_FLAG_STATEFUL_FUNC |
+                           KVM_CPUID_FLAG_STATE_READ_NEXT;
+            }
 
             for (j = 1; j < times; ++j) {
                 if (cpuid_i == KVM_MAX_CPUID_ENTRIES) {