tools: ynl: Initialise fixed headers to 0 in genetlink-legacy
authorDonald Hunter <donald.hunter@gmail.com>
Sat, 27 May 2023 13:31:05 +0000 (14:31 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 30 May 2023 05:05:38 +0000 (22:05 -0700)
This eliminates the need for e.g. --json '{"dp-ifindex":0}' which is not
too big a deal for ovs but will get tiresome for fixed header structs that
have many members.

Signed-off-by: Donald Hunter <donald.hunter@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/net/ynl/lib/ynl.py

index 39a2296c0003b659d21c8228eb38ab42f5483be9..85ee6a4bee72d8053dd35c0325788b852888c656 100644 (file)
@@ -541,7 +541,7 @@ class YnlFamily(SpecFamily):
         if op.fixed_header:
             fixed_header_members = self.consts[op.fixed_header].members
             for m in fixed_header_members:
-                value = vals.pop(m.name)
+                value = vals.pop(m.name) if m.name in vals else 0
                 format = NlAttr.get_format(m.type, m.byte_order)
                 msg += format.pack(value)
         for name, value in vals.items():