leds: trigger: gpio: Avoid warning on update of inverted
authorJan Kiszka <jan.kiszka@siemens.com>
Sat, 13 Jun 2020 07:15:06 +0000 (09:15 +0200)
committerPavel Machek <pavel@ucw.cz>
Sun, 12 Jul 2020 08:06:38 +0000 (10:06 +0200)
If the GPIO has not been configured yet, writing to inverted will raise
a kernel warning.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
drivers/leds/trigger/ledtrig-gpio.c

index dc64679b1a9243c9219f8070de9ce6f5cc396d25..0120faa3dafa644f61d94d544b47400c5f4744c2 100644 (file)
@@ -99,7 +99,8 @@ static ssize_t gpio_trig_inverted_store(struct device *dev,
        gpio_data->inverted = inverted;
 
        /* After inverting, we need to update the LED. */
-       gpio_trig_irq(0, led);
+       if (gpio_is_valid(gpio_data->gpio))
+               gpio_trig_irq(0, led);
 
        return n;
 }