wil6210: fix break that is never reached because of zero'ing of a retry counter

There is a check on the retry counter invalid_buf_id_retry that is always
false because invalid_buf_id_retry is initialized to zero on each iteration
of a while-loop.  Fix this by initializing the retry counter before the
while-loop starts.

Addresses-Coverity: ("Logically dead code")
Fixes: b4a967b7d0f5 ("wil6210: reset buff id in status message after completion")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Maya Erez <merez@codeaurora.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

diff --git a/drivers/net/wireless/ath/wil6210/txrx_edma.c b/drivers/net/wireless/ath/wil6210/txrx_edma.c
index 778b63be6a9a477fa0dc2dd84049d42b4a2d535a..02548d40253c7fce67387554fb1954e48fe434a5 100644 (file)
--- a/drivers/net/wireless/ath/wil6210/txrx_edma.c
+++ b/drivers/net/wireless/ath/wil6210/txrx_edma.c
@@ -869,6 +869,7 @@ static struct sk_buff *wil_sring_reap_rx_edma(struct wil6210_priv *wil,
        u8 data_offset;
        struct wil_rx_status_extended *s;
        u16 sring_idx = sring - wil->srings;
+       int invalid_buff_id_retry;
 
        BUILD_BUG_ON(sizeof(struct wil_rx_status_extended) > sizeof(skb->cb));
 
@@ -882,9 +883,9 @@ again:
        /* Extract the buffer ID from the status message */
        buff_id = le16_to_cpu(wil_rx_status_get_buff_id(msg));
 
+       invalid_buff_id_retry = 0;
        while (!buff_id) {
                struct wil_rx_status_extended *s;
-               int invalid_buff_id_retry = 0;
 
                wil_dbg_txrx(wil,
                             "buff_id is not updated yet by HW, (swhead 0x%x)\n",