net: hns: Annotate struct ppe_common_cb with __counted_by
authorKees Cook <keescook@chromium.org>
Fri, 22 Sep 2023 17:28:46 +0000 (10:28 -0700)
committerJakub Kicinski <kuba@kernel.org>
Mon, 2 Oct 2023 18:24:52 +0000 (11:24 -0700)
Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
(for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).

As found with Coccinelle[1], add __counted_by for struct ppe_common_cb.

[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci

Cc: Yisen Zhuang <yisen.zhuang@huawei.com>
Cc: Salil Mehta <salil.mehta@huawei.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/20230922172858.3822653-4-keescook@chromium.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.h

index 0f0e16f9afc0d7cc5b6cb9dbe0d2cfd7d596107f..7e00231c1acfac5d729f36c9722a43c9ba2a94c1 100644 (file)
@@ -92,7 +92,7 @@ struct ppe_common_cb {
        u8 comm_index;   /*ppe_common index*/
 
        u32 ppe_num;
-       struct hns_ppe_cb ppe_cb[];
+       struct hns_ppe_cb ppe_cb[] __counted_by(ppe_num);
 
 };