scsi: mpi3mr: Fix error code in mpi3mr_transport_smp_handler()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 15 Sep 2022 11:11:04 +0000 (14:11 +0300)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 16 Sep 2022 02:04:02 +0000 (22:04 -0400)
The error code from mpi3mr_post_transport_req() is supposed to be passed to
bsg_job_done(job, rc, reslen), but it isn't.

Link: https://lore.kernel.org/r/YyMISJzVDARpVwrr@kili
Fixes: 176d4aa69c6e ("scsi: mpi3mr: Support SAS transport class callbacks")
Acked-by: Sathya Prakash Veerichetty <sathya.prakash@broadcom.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/mpi3mr/mpi3mr_transport.c

index 74313cf68ad34942829eb8446c374d687596f680..3fc897336b5e097ac1f80eeb37546b381eb02874 100644 (file)
@@ -3245,8 +3245,10 @@ mpi3mr_transport_smp_handler(struct bsg_job *job, struct Scsi_Host *shost,
 
        dprint_transport_info(mrioc, "sending SMP request\n");
 
-       if (mpi3mr_post_transport_req(mrioc, &mpi_request, request_sz,
-           &mpi_reply, reply_sz, MPI3MR_INTADMCMD_TIMEOUT, &ioc_status))
+       rc = mpi3mr_post_transport_req(mrioc, &mpi_request, request_sz,
+                                      &mpi_reply, reply_sz,
+                                      MPI3MR_INTADMCMD_TIMEOUT, &ioc_status);
+       if (rc)
                goto unmap_in;
 
        dprint_transport_info(mrioc,