bpf: Minor logging improvement
authorAndrei Matei <andreimatei1@gmail.com>
Mon, 4 Dec 2023 01:12:48 +0000 (20:12 -0500)
committerDaniel Borkmann <daniel@iogearbox.net>
Mon, 4 Dec 2023 14:57:27 +0000 (15:57 +0100)
One place where we were logging a register was only logging the variable
part, not also the fixed part.

Signed-off-by: Andrei Matei <andreimatei1@gmail.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/20231204011248.2040084-1-andreimatei1@gmail.com
kernel/bpf/verifier.c

index 2cd150d6d141ed015e15c04b214c89171045af25..cdb4f5f0ba79d4f4283bc34c526fdc64675bab77 100644 (file)
@@ -6585,8 +6585,8 @@ static int check_stack_access_within_bounds(
                        char tn_buf[48];
 
                        tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
-                       verbose(env, "invalid variable-offset%s stack R%d var_off=%s size=%d\n",
-                               err_extra, regno, tn_buf, access_size);
+                       verbose(env, "invalid variable-offset%s stack R%d var_off=%s off=%d size=%d\n",
+                               err_extra, regno, tn_buf, off, access_size);
                }
        }
        return err;