clk: sunxi-ng: sun8i-de2: Use dev_err_probe() helper
authorYang Yingliang <yangyingliang@huawei.com>
Sat, 27 Aug 2022 09:41:49 +0000 (17:41 +0800)
committerJernej Skrabec <jernej.skrabec@gmail.com>
Thu, 8 Sep 2022 19:59:01 +0000 (21:59 +0200)
dev_err() can be replace with dev_err_probe() which will check if error
code is -EPROBE_DEFER.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Link: https://lore.kernel.org/r/20220827094151.3323450-1-yangyingliang@huawei.com
drivers/clk/sunxi-ng/ccu-sun8i-de2.c

index 2f6f02f00be24f7f25f3d1829bd8f335e931f9f3..b70b312e74836fef0b3aed9607adf78c7cbf0155 100644 (file)
@@ -256,29 +256,19 @@ static int sunxi_de2_clk_probe(struct platform_device *pdev)
                return PTR_ERR(reg);
 
        bus_clk = devm_clk_get(&pdev->dev, "bus");
-       if (IS_ERR(bus_clk)) {
-               ret = PTR_ERR(bus_clk);
-               if (ret != -EPROBE_DEFER)
-                       dev_err(&pdev->dev, "Couldn't get bus clk: %d\n", ret);
-               return ret;
-       }
+       if (IS_ERR(bus_clk))
+               return dev_err_probe(&pdev->dev, PTR_ERR(bus_clk),
+                                    "Couldn't get bus clk\n");
 
        mod_clk = devm_clk_get(&pdev->dev, "mod");
-       if (IS_ERR(mod_clk)) {
-               ret = PTR_ERR(mod_clk);
-               if (ret != -EPROBE_DEFER)
-                       dev_err(&pdev->dev, "Couldn't get mod clk: %d\n", ret);
-               return ret;
-       }
+       if (IS_ERR(mod_clk))
+               return dev_err_probe(&pdev->dev, PTR_ERR(mod_clk),
+                                    "Couldn't get mod clk\n");
 
        rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL);
-       if (IS_ERR(rstc)) {
-               ret = PTR_ERR(rstc);
-               if (ret != -EPROBE_DEFER)
-                       dev_err(&pdev->dev,
-                               "Couldn't get reset control: %d\n", ret);
-               return ret;
-       }
+       if (IS_ERR(rstc))
+               return dev_err_probe(&pdev->dev, PTR_ERR(rstc),
+                                    "Couldn't get reset control\n");
 
        /* The clocks need to be enabled for us to access the registers */
        ret = clk_prepare_enable(bus_clk);