scsi: bsg: Fix commands without data transfer in scsi_bsg_sg_io_fn()

Set ret to 0 after the initial permission checks to avoid leaking -EPERM
for commands without data transfer.

Link: https://lore.kernel.org/r/20210731074027.1185545-2-hch@lst.de
Fixes: 75ca56409e5b ("scsi: bsg: Move the whole request execution into the SCSI/transport handlers")
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/scsi_bsg.c b/drivers/scsi/scsi_bsg.c
index d13a67b8242912da486d6dbf8a24a6b1a194ee1c..81c3853a2a8003fa1110a9294c3dc5180e7d5145 100644 (file)
--- a/drivers/scsi/scsi_bsg.c
+++ b/drivers/scsi/scsi_bsg.c
@@ -47,6 +47,7 @@ static int scsi_bsg_sg_io_fn(struct request_queue *q, struct sg_io_v4 *hdr,
        if (!scsi_cmd_allowed(sreq->cmd, mode))
                goto out_free_cmd;
 
+       ret = 0;
        if (hdr->dout_xfer_len) {
                ret = blk_rq_map_user(rq->q, rq, NULL, uptr64(hdr->dout_xferp),
                                hdr->dout_xfer_len, GFP_KERNEL);