ext4: drop pointless IO submission from ext4_bio_write_page()
authorJan Kara <jack@suse.cz>
Wed, 7 Dec 2022 11:27:07 +0000 (12:27 +0100)
committerTheodore Ts'o <tytso@mit.edu>
Fri, 9 Dec 2022 02:49:25 +0000 (21:49 -0500)
We submit outstanding IO in ext4_bio_write_page() if we find a buffer we
are not going to write. This is however pointless because we already
handle submission of previous IO in case we detect newly added buffer
head is discontiguous. So just delete the pointless IO submission call.

Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20221207112722.22220-4-jack@suse.cz
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/page-io.c

index 2bdfb8a046d9feaf9b323f7db390625459218e8d..beaec6d81074a7e21c5ea3123700bd8332859a58 100644 (file)
@@ -489,8 +489,6 @@ int ext4_bio_write_page(struct ext4_io_submit *io,
                                        redirty_page_for_writepage(wbc, page);
                                keep_towrite = true;
                        }
-                       if (io->io_bio)
-                               ext4_io_submit(io);
                        continue;
                }
                if (buffer_new(bh))